This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
7/11 master -> stable #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R=arv BUG= Review URL: https://codereview.appspot.com/10361043
…eated Note that this also allows for the common case of inserting an instance via a DocumentFragment. Only if there is a instanceCache hit, do we insert an array of nodes. R=arv BUG= Review URL: https://codereview.appspot.com/10361044
… Object.observe. Many were suffering from: #64 and also lack of calls to Platform.performMicrotaskCheckpoint(). Also, the twitter rest API 1.0 is now gone and the 1.1 API requires auth, so I removed the example for now. R=arv BUG= Review URL: https://codereview.appspot.com/10383044
R=arv BUG= Review URL: https://codereview.appspot.com/10442044
remove extra argument to extractInstanceAt
Arv, this is more of an FYI, that a review. I'll let you decide how close you need to look at this code. Basically I wanted to just get something in place to start looking at MDV perf. TBR=arv BUG= Review URL: https://codereview.appspot.com/10876045
R=arv BUG= Review URL: https://codereview.appspot.com/10883043
…ng-map R=arv BUG= Review URL: https://codereview.appspot.com/10858044
This patch goes along with googlearchive/observe-js@75c4e83. The idea here is that chained observation needs a way to clean itself up. These two changes make this a concern of the observers rather than the bindings inside MDV. It is now the case that for all observed objects, if they have a .unobserved property which is a function, it is invoked when observation ends. R=arv BUG= Review URL: https://codereview.appspot.com/10924044
R=arv BUG= Review URL: https://codereview.appspot.com/10890044
…e.bindings R=arv BUG= Review URL: https://codereview.appspot.com/10886045
…e weakly held) R=arv BUG= Review URL: https://codereview.appspot.com/10761049
…n, and use a logorithmic density scale R=arv BUG= Review URL: https://codereview.appspot.com/10950043
…sequent iterations. Collect bindings for quick destruction of instances R=arv BUG= Review URL: https://codereview.appspot.com/10935044
I mostly did it this way so that all bindings can share hidden classes. Oh well. R=arv BUG= Review URL: https://codereview.appspot.com/11064043
This is on the critical path if there are lots of compound bindings in iterated template. R=arv BUG= Review URL: https://codereview.appspot.com/11077043
BUG= Review URL: https://codereview.appspot.com/10705044
R=arv BUG= Review URL: https://codereview.appspot.com/10707049
This broke the Polymer sandbox app somehow. Reverting this part until I can figure out why. R=arv BUG= Review URL: https://codereview.appspot.com/10949045
R=arv BUG= Review URL: https://codereview.appspot.com/11018044
This reverts commit dd83a79. BUG= Review URL: https://codereview.appspot.com/10765045
R=arv BUG= Review URL: https://codereview.appspot.com/11127043
Conflicts: sample.html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.